-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a NoDCHydrate feature to defer DC creation to step 3 #596
Conversation
- Refactor the DC Hydration code out - Add a mode to avoid dehydrating the DC and to instead create it during deployment - Add support for Server 2025 images by name
@Karl-WE i will look on this over the weekend, I want to test this scenario also with older versions of win server before merging. |
Thank you for going the extra mile @machv |
Thank you, @machv . I did test with Server 2022, but it would be great to get independent confirmation. I'm happy to fix anything you find. I got into this just to fix the issue for Karl but I'm growing rather fond of these scripts. |
Folks, I added some more stuff into DC hydration as I found breaking bug in networking stack. So now it also installs Hyper-V in DC and adds vswitch. It simplifies a bit this scenario https://github.com/DellGEOS/AzureStackHOLs/tree/main/lab-guides/04-TestingLogicalNetworks. Unfortunately it will also break this PR. I also added Ws2025 version into parent disks creation, so it will no longer be created as insider preview vhd. |
Thanks, @jaromirk -- I merged your changes and re-pushed. I re-tested Server 2025 (with NoDehydrateDC=$true) and Server 2022 (with NoDehydrateDC=$false). |
Tested with
The original issue in #589 is solved. @michbern-ms @jaromirk please decide if this code change is still helpful, just in case we see a reprise of the issue of importing hydrated VMs with later Windows Server versions |
This change creates a NoDCHydrate feature to defer DC creation to step 3.
This works around an issue where the Server 2025 Domain Controller does not respond well to being dehydrated and rehydrated.
The change also adds named-VHD support for WS2025.