Skip to content

Commit

Permalink
Merge pull request #130 from microsoft/user/dcook/LinuxTracepoints0.2.0
Browse files Browse the repository at this point in the history
PerfDataExtension - upgrade to LinuxTracepoints 0.2.0
  • Loading branch information
idigdoug authored Jun 20, 2024
2 parents f88ebc4 + 0b3af64 commit 4a9bdc7
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 13 deletions.
6 changes: 3 additions & 3 deletions PerfDataExtension/PerfDataExtension.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<PropertyGroup>
<TargetFramework>netstandard2.1</TargetFramework>
<OutputType>Library</OutputType>
<Version>0.1.3</Version>
<Version>0.2.0</Version>
<PackageRequireLicenseAcceptance>True</PackageRequireLicenseAcceptance>
<Authors>Microsoft</Authors>
<Company>Microsoft</Company>
Expand Down Expand Up @@ -44,10 +44,10 @@
<ItemGroup>
<PackageReference Include="Microsoft.Performance.SDK" Version="1.1.24" />

<PackageReference Include="Microsoft.LinuxTracepoints.Types" Version="0.1.2.*" PrivateAssets="all" GeneratePathProperty="true" />
<PackageReference Include="Microsoft.LinuxTracepoints.Types" Version="0.2.0.*" PrivateAssets="all" GeneratePathProperty="true" />
<CopyToTargetDir Include="$(PkgMicrosoft_LinuxTracepoints_Types)\lib\netstandard2.1\Microsoft.LinuxTracepoints.Types.dll" />

<PackageReference Include="Microsoft.LinuxTracepoints.Decode" Version="0.1.2.*" PrivateAssets="all" GeneratePathProperty="true" />
<PackageReference Include="Microsoft.LinuxTracepoints.Decode" Version="0.2.0.*" PrivateAssets="all" GeneratePathProperty="true" />
<CopyToTargetDir Include="$(PkgMicrosoft_LinuxTracepoints_Decode)\lib\netstandard2.1\Microsoft.LinuxTracepoints.Decode.dll" />
</ItemGroup>

Expand Down
12 changes: 6 additions & 6 deletions PerfDataExtension/PerfDataFormatter.cs
Original file line number Diff line number Diff line change
Expand Up @@ -483,13 +483,13 @@ public KeyValuePair<string, string>[] MakeRowSynchronized(
var field = fields[fieldIndex + commonFieldCount];
var fieldVal = field.GetFieldValue(rawData, byteReader);
sb.Clear();
if (fieldVal.Type.IsArrayOrElement)
if (fieldVal.Metadata.IsScalar)
{
fieldVal.AppendSimpleArrayTo(sb, convertOptions);
fieldVal.AppendScalarTo(sb, convertOptions);
}
else
{
fieldVal.AppendScalarTo(sb, convertOptions);
fieldVal.AppendSimpleArrayTo(sb, convertOptions);
}

row[fieldIndex] = new KeyValuePair<string, string>(field.Name, this.BuilderIntern());
Expand Down Expand Up @@ -547,13 +547,13 @@ private void AppendFieldAsJson(PerfByteReader byteReader, ReadOnlySpan<byte> raw
}

var fieldVal = field.GetFieldValue(rawData, byteReader);
if (fieldVal.Type.IsArrayOrElement)
if (fieldVal.Metadata.IsScalar)
{
fieldVal.AppendJsonSimpleArrayTo(this.builder, convertOptions);
fieldVal.AppendJsonScalarTo(this.builder, convertOptions);
}
else
{
fieldVal.AppendJsonScalarTo(this.builder, convertOptions);
fieldVal.AppendJsonSimpleArrayTo(this.builder, convertOptions);
}
}

Expand Down
6 changes: 3 additions & 3 deletions PerfDataExtension/PerfDataSourceParser.cs
Original file line number Diff line number Diff line change
Expand Up @@ -229,10 +229,10 @@ public override void ProcessSource(
structFields -= 1;
}

var type = enumerator.GetItemType();
if (type.Encoding == EventHeaderFieldEncoding.Struct)
var itemMetadata = enumerator.GetItemMetadata();
if (itemMetadata.Encoding == EventHeaderFieldEncoding.Struct)
{
structFields += type.StructFieldCount;
structFields += itemMetadata.StructFieldCount;
}
}

Expand Down
2 changes: 1 addition & 1 deletion PerfDataExtension/pluginManifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"$schema": "https://raw.githubusercontent.com/microsoft/microsoft-performance-toolkit-sdk/main/src/PluginsSystem/Tools/Microsoft.Performance.Toolkit.Plugins.Cli/Manifest/PluginManifestSchema.json",
"identity": {
"id": "Microsoft.Performance.Toolkit.Plugins.PerfDataExtension",
"version": "0.1.3"
"version": "0.2.0"
},
"displayName": "Linux - Perf",
"description": "Enables loading Linux events from perf.data files (e.g. generated by the perf tool)",
Expand Down

0 comments on commit 4a9bdc7

Please sign in to comment.