Clarify ASan test running instructions

[davidmrdavid]

This is an exceedingly minor contribution, so feel free to disregard it.

When running the ASan'ized tests, I could have used a reminder that the python test script resides within the .\out\<arch> folder. The preceeding cmake commands should run in the repo's root, so it's easy to forget changing your directory when running the python <pathToTestScript>/stl-lit.py command.

This PR adds a reminder that the call to stl-lit.py should be performed from out\x64\ , to make this clearer.

Please feel free to dismiss this, it's a subjective contribution. Thanks!

[davidmrdavid]

naive question: should I go ahead and squash-and-merge is there a procedure to this?

[CaseyCarter]

naive question: should I go ahead and squash-and-merge is there a procedure to this?

We hand-port all changes into the MSVC repo and merge in both places "simultaneously" to minimize divergence between the internal and external copies of the STL. Yes, this is a bit of a PITA. We generally merge a batch of PRs every few days to amortize the annoyance of the port and the cost of the internal CI. The process is documented in https://github.com/microsoft/STL/wiki/Checklist-For-Merging-A-Pull-Request.

TLDR: No, we'll squash and merge it later. Your work is done here once the PR reaches the "Ready to Merge" state. Right now it's at "Final Review" because I want to see if STL is bothered by the ASan instructions using the top of the repo as working directory instead of using out/x64 like the non-ASan instructions do.

[StephanTLavavej]

I want to see if STL is bothered by the ASan instructions using the top of the repo as working directory instead of using out/x64 like the non-ASan instructions do.

Yeah, this really bothers me. It's unnecessarily different from the normal test instructions which begin by saying:

These examples assume that your current directory is C:\Dev\STL\out\x64.

I'll push a change.

[StephanTLavavej]

Change pushed (and PR title and description updated).

Sorry to be so nitpicky, but I believe that following a consistent pattern is important. Running the tests from out\<arch> has a couple of benefits: (1) if you run a different arch (commonly x86), you only need to alter your pushd command, and (2) if you create any log or temp files while investigating tests, they'll be safely contained within the out tree instead of polluting the repo root.

[davidmrdavid]

no problem at all, it's good for me to absorb these documentation values for future PRs, so I appreciate them being laid out explicitly. Thanks!