[WIP] Add naive first implementation of per-allocator disablement of ASan #5241
+63
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
requested changes
Jan 16, 2025
stl/inc/vector
Outdated
| @@ -493,6 +493,10 @@ private: | |||
| return; | |||
| } | |||
|
|
|||
| if (!is_ASan_enabled_for_allocator_v<allocator_type>) { | |||
There was a problem hiding this comment.
Since this is testing a constant expression, it should probably be an if constexpr containing the entire function body so we don't bother to so much as compile it.
There was a problem hiding this comment.
constexpr'ed all the things: 71c7716
There was a problem hiding this comment.
I guess it's better to write
if constexpr (is_ASan_enabled_for_allocator_v<allocator_type>) {
// ASan stuffs
}There was a problem hiding this comment.
Yeah I thought about that as well. In this case we're inside the _Apply_annotation method which, to my understanding, is already ASan-specific. I figure we wouldn't want to indent all of the remaining code to be inside the if-statement.
Do let me know if I'm misunderstanding something though :-)
Co-authored-by: Casey Carter <[email protected]>
Co-authored-by: Casey Carter <[email protected]>
StephanTLavavej
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP, opening for visibility and checkpointing only.