Bugs

microsoft · Feb 4, 2025 · b6c63cc · b6c63cc
1 parent e553cab
commit b6c63cc
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/ts/packages/knowPro/src/dataFormat.ts b/ts/packages/knowPro/src/dataFormat.ts
@@ -89,7 +89,7 @@ export interface IConversation<TMeta extends IKnowledgeSource = any> {
     semanticRefs: SemanticRef[] | undefined;
     semanticRefIndex?: ITermToSemanticRefIndex | undefined;
     propertyToSemanticRefIndex: IPropertyToSemanticRefIndex | undefined;
-    relatedTermsIndex?: ITermToRelatedTermsIndex | undefined;
+    termToRelatedTermsIndex?: ITermToRelatedTermsIndex | undefined;
     timestampIndex?: ITimestampToTextRangeIndex | undefined;
 }
 

diff --git a/ts/packages/knowPro/src/relatedTermsIndex.ts b/ts/packages/knowPro/src/relatedTermsIndex.ts
@@ -74,12 +74,14 @@ export async function resolveRelatedTerms(
     relatedTermsIndex: ITermToRelatedTermsIndex,
     searchTerms: SearchTerm[],
 ): Promise<void> {
-    // Resolve any hardcoded mappings
     for (const searchTerm of searchTerms) {
         const termText = searchTerm.term.text;
+        // Resolve any specific term to related term mappings
         if (!searchTerm.relatedTerms || searchTerm.relatedTerms.length === 0) {
             searchTerm.relatedTerms = relatedTermsIndex.lookupTerm(termText);
         }
+        // If no hard-coded mappings, lookup any fuzzy related terms
+        // Future: do this in batch
         if (!searchTerm.relatedTerms || searchTerm.relatedTerms.length === 0) {
             searchTerm.relatedTerms =
                 await relatedTermsIndex.lookupTermFuzzy(termText);

diff --git a/ts/packages/knowPro/src/search.ts b/ts/packages/knowPro/src/search.ts
@@ -185,9 +185,9 @@ class SearchQueryBuilder {
     }
 
     private async prepareSearchTerms(searchTerms: SearchTerm[]): Promise<void> {
-        if (this.conversation.relatedTermsIndex) {
+        if (this.conversation.termToRelatedTermsIndex) {
             await resolveRelatedTerms(
-                this.conversation.relatedTermsIndex,
+                this.conversation.termToRelatedTermsIndex,
                 searchTerms,
             );
         }