Added AzLinux-dnf support for RedisPackageInstallation #417
Conversation
Signed-off-by: Rakesh <[email protected]>
src/VirtualClient/VirtualClient.Dependencies/RedisPackageInstallation.cs
Outdated
Show resolved
Hide resolved
| @@ -55,22 +55,10 @@ | |||
| } | |||
| }, | |||
| { | |||
| "Type": "WgetPackageInstallation", | |||
There was a problem hiding this comment.
Have you tested the changes in ubuntu?
There was a problem hiding this comment.
There seems to be some issue with Redis, entering protected mode in ubuntu even without these changes, but the changes were running fine on AZ Linux.
src/VirtualClient/VirtualClient.Dependencies/RedisPackageInstallation.cs
Show resolved
Hide resolved
| @@ -154,5 +160,35 @@ await this.systemManager.PackageManager.RegisterPackageAsync(redisPackage, cance | |||
| .ConfigureAwait(false); | |||
|
|
|||
| } | |||
|
|
|||
| private async Task InstallOnAzLinuxAsync(EventContext telemetryContext, CancellationToken cancellationToken) | |||
There was a problem hiding this comment.
tdnf also works, is it preferred!?
There was a problem hiding this comment.
on AzLinux yes, on RHEL still use dnf. You don;t have to change it right now, you could add a comment that tdnf also works. I heard AzLinux eventually wants to move to tdnf entirely
| @@ -154,5 +160,35 @@ await this.systemManager.PackageManager.RegisterPackageAsync(redisPackage, cance | |||
| .ConfigureAwait(false); | |||
|
|
|||
| } | |||
|
|
|||
| private async Task InstallOnAzLinuxAsync(EventContext telemetryContext, CancellationToken cancellationToken) | |||
There was a problem hiding this comment.
I believe this would also work on RHEL/Fedora distros?
There was a problem hiding this comment.
Yes, but I haven't tested these cases. Should I also include RHEL/Fedora distros?
There was a problem hiding this comment.
I think so, Redis is important enough that we need more than ubuntu and AzLinux
No description provided.