Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

[spike] remove callout component #372

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[spike] remove callout component #372

wants to merge 4 commits into from

Conversation

chrismohr
Copy link
Contributor

@chrismohr chrismohr commented Jun 7, 2018

padding: '0.7rem 1.2rem 0.8rem',
minHeight: '3.2rem',
zIndex: 1000,
border: 'none',
...borderStylePopOver,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Find out if tooltip should have this style.

@chrismohr
Copy link
Contributor Author

Also waiting on #368 to ensure we don't regress for MenuButton

@chrismohr
Copy link
Contributor Author

This is blocked because there is currently no way of styling the Callout used by Fabric's SuggestionListBasePicker used by our Picker.

@unindented
Copy link
Contributor

Given that our design team is trying to move towards Fabric's styles anyways, should we stop customizing the callout?

@chrismohr
Copy link
Contributor Author

@unindented Good question. Given how busy I've perceived our design team to be. I've been holding off bringing these decisions to them, and hoping/expecting that once they've regrouped, we'll start working more closely together and address these en masse. You're probably more plugged in than I am though. What do you recommend?

@unindented
Copy link
Contributor

Yup, I think you're right. Let's wait for them to regroup.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants