-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make AgentChat Team Config Serializable #5071
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5071 +/- ##
==========================================
+ Coverage 70.53% 70.80% +0.27%
==========================================
Files 174 174
Lines 11129 11229 +100
==========================================
+ Hits 7850 7951 +101
+ Misses 3279 3278 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Some updates on this effort on here so we can have a broader discussion. There are a few current issues with making teams declarative (or more generally - elements that inherit from a protocol cannot be declarative in the current setup without mypy/build errors). The short story is that:
Similar situation with SocietyofMindAgent. It has a team field that inherits from the Team protocol. While we can serialize base Team classes, mypy still fails as the Team protocol itself cannot cannot inherit from ComponentBase. Some potential solutions/directions
Edit: Resolution -> we are moving to ABC's for components. |
Just a comment on the name. This work is not to make agent chat declarative -- the agentchat API is already declartive. It is to make the configuration serializable. So should update the title and fix how we mention it for precise language. |
Why are these changes needed?
Support a developer experience where an AgentChat team configuration can be serialized to a declarative specification.
TBD
Related issue number
Closes #5064
Checks