Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: Use Node 20 instead of Node 16 #1132

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

BREAKING CHANGE: Use Node 20 instead of Node 16 #1132

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91fda6c
feat(node-20): Use Node 20 instead of Node 16
DaveTryon Oct 20, 2023
b336138
Resolving branch conflicts
v-singhanjal Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,10 @@ jobs:
vmImage: 'ubuntu-22.04'

steps:
# This is later than the minimum version the package claims support
# for because semantic-release requires a later LTS version that we
# can require of our users without a breaking change
- task: NodeTool@0
inputs:
versionSpec: '18.17.0'
displayName: use node 18.17.0
versionSpec: '20.x'
displayName: use node 20.x

- script: yarn install --immutable
displayName: yarn install
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"README.md"
],
"engines": {
"node": ">= 8"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8 to 20 feels like a big jump. Is the intent to use features that require Node >= 20 in future commits?

"node": ">= 20"
},
"packageManager": "[email protected]",
"dependencies": {
Expand Down