Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize byte flushing in bool_writer #130

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Optimize byte flushing in bool_writer #130

merged 4 commits into from
Dec 20, 2024

Conversation

mcroomp
Copy link
Collaborator

@mcroomp mcroomp commented Dec 17, 2024

Significantly shrinks the size of the main loop, which helps a bit on Intel. Also simplifies the logic of the way the marker bit is maintained.

@mcroomp mcroomp requested review from Melirius and Copilot December 17, 2024 18:48

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Copy link
Collaborator

@Melirius Melirius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to check performance on my box.

Copy link
Collaborator

@Melirius Melirius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same perf for me, approve.

@Melirius Melirius merged commit 4460093 into main Dec 20, 2024
3 checks passed
@Melirius Melirius deleted the vpxwriter branch December 20, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants