Add WrapperDecompressImageEx API that supports use_16bit_dc_estimate #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C++ version has a bug where it uses 16 bit math in the SIMD path and 32 bit math in the scalar path depending on the compiler options. This PR adds a new WrapperDecompressImageEx API that supports use_16bit_dc_estimate argument.
If use_16bit_dc_estimate=true, the decompression uses a back-compat mode that considers it. The caller should set use_16bit_dc_estimate to true only for images that were compressed by C++ version with relevant compiler options. This approach is preferrable to a previously added retry logic that may miss some cases leading to bad (corrupted) decompression results.