added scalar overflow handling #57
Merged
+174
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbrovman
reviewed
Feb 20, 2024
gbrovman
reviewed
Feb 20, 2024
gbrovman
requested changes
Feb 20, 2024
There was a problem hiding this comment.
I think that use_16bit_dc_estimate param to the DecompressWrapper function should become use_scalar_lepton and to control both flags - use_16bit_dc_estimate and use_16bit_adv_predict. Also, is there are a reason to keep these flags separated in EnabledFeatures?
gbrovman
reviewed
Feb 22, 2024
gbrovman
requested changes
Feb 22, 2024
m6w6
suggested changes
Feb 29, 2024
|
Thanks for fixing! |
gbrovman
reviewed
Mar 14, 2024
| @@ -159,14 +159,19 @@ pub unsafe extern "C" fn WrapperDecompressImageEx( | |||
| ) -> i32 { | |||
There was a problem hiding this comment.
In the comment above please update the description to "that were compressed by C++ SIMD version of Lepton"
gbrovman
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One other place where there was a difference between the 32 bit scalar and 16 bit SIMD code. Unfortunately this is the opposite behavior of what was there before, so for backward compat I had to add another feature setting for that.