Switch to using the Rayon threadpool instead of spawning threads for each work item #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbrovman
approved these changes
Apr 8, 2024
| @@ -311,7 +309,7 @@ fn run_lepton_decoder_threads<R: Read + Seek, P: Send>( | |||
| lh: &LeptonHeader, | |||
| reader: &mut R, | |||
| last_data_position: u64, | |||
| max_threads_to_use: usize, | |||
| _max_threads_to_use: usize, | |||
There was a problem hiding this comment.
Why it's not used anymore? I'd expect it to be used similar C# ThreadPool MaxParallelization, if it is supported in Rayon.
There was a problem hiding this comment.
kind of a global thing so its hard to set as part of the api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a result of the investigation on high CPU usage, which appears to be caused by large numbers of threads starting/stopping.
This will result in less obnoxious CPU usage since Rayon is a highly optimized threadpool that is able of grow/shrink as work items become available.
There is a minor change in behavior where we don't try to merge work items on read anymore, since the threadpool already is responsible for making sure that we don't fan out too broadly.