Improve testability and add tests to the way that blocks of coefficients are encoded #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble across all platforms
|
LGTM |
Melirius
reviewed
Apr 25, 2024
|
Yeah that’s a dumb name agree
@Melirius commented on this pull request.
In src/structs/lepton_decoder.rs <#69 (comment)> :
@@ -289,30 +289,49 @@ fn parse_token<R: Read, const ALL_PRESENT: bool>(
) -> Result<()> {
debug_assert!(pt.is_all_present() == ALL_PRESENT);
+ let neighbors =
+ context.get_neighbor_data::<ALL_PRESENT>(image_data, context, num_non_zeros, pt);
What about renaming num_non_zeros? It is not the only and not even the main component of NeighborSummary.
|
Melirius
reviewed
Apr 25, 2024
src/structs/probability_tables.rs
Outdated
| @@ -92,17 +91,16 @@ impl ProbabilityTables { | |||
|
|
|||
| pub fn calc_non_zero_counts_context_7x7<const ALL_PRESENT: bool>( | |||
There was a problem hiding this comment.
I think: what if rename this to calc_non_zero_counts_predictor_7x7 or smth like that and return num_non_zeros_above << 1, num_non_zeros_left << 1 or num_non_zeros_above + num_non_zeros_left. Then by extending array NON_ZERO_TO_BIN to 100 bytes we can reduce number of operations per coefficient.
There was a problem hiding this comment.
We can even return bin directly from here.
There was a problem hiding this comment.
I'll separate this in another change... better to separate refactoring from functional changes
|
Nice! |
Melirius
reviewed
Apr 25, 2024
Co-authored-by: Ivan Siutsou <[email protected]> Signed-off-by: Kristof Roomp <[email protected]>
Melirius
reviewed
Apr 26, 2024
This reverts commit a29377b.
Melirius
reviewed
Apr 27, 2024
gbrovman
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add read_coefficients and write_coefficients that encapsulate the read/write process and can be testing individually without pulling in the world.
This also allows for testing with hardcoded known good values to make it easier to catch any subtle changes that could cause backwards compat issues.