Simplify nonzero edge decoding / encoding #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te the bitlength when we actually need it
Melirius
reviewed
May 9, 2024
Melirius
reviewed
May 9, 2024
Comment on lines
+128
to
+136
| // No need to go to 32 bits since max exponent is 11, ie 2047, so | ||
| // (2047 + 2047) * 13 + 2047 * 6 = 65504 which still fits in 16 bits. | ||
| // In addition, if we ever returned anything higher that 2047, it would | ||
| // assert in the array lookup in the model. | ||
| best_prior[i] = ((left.get_coefficient(i).unsigned_abs() | ||
| + above.get_coefficient(i).unsigned_abs()) | ||
| * 13 | ||
| + 6 * above_left.get_coefficient(i).abs() as u32) | ||
| >> 5) as i16; | ||
| + 6 * above_left.get_coefficient(i).unsigned_abs()) | ||
| >> 5; |
Melirius
approved these changes
May 9, 2024
Merged
gbrovman
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove ProbabilityTablesCoefficientContext and calculate the values when actually needed. This means that we can range check the values at the same place that does the array lookup, which means no range check effectively. It also means that we can recycle the absolute value calculation on the best_prior.
Overall this speeds up execution about 1.5% and simplifies the code as well.