Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PY] fix: streaming - citations & pyproject.toml updates #2205

Merged
merged 39 commits into from
Jan 7, 2025

Conversation

lilyydu
Copy link
Contributor

@lilyydu lilyydu commented Nov 25, 2024

Linked issues

closes: #minor

Details

match with #2185 and #2202,

image

  • citations is now enabled during streaming, and for the final message
  • updated colour/outline pngs for sample to adhere to manifest validation
  • fixed indexing for citations position
  • added StreamingEntity class to fix serialization on streaminfo object
  • version 2 of poetry was released which led to a few scripts failing

Attestation Checklist

  • My code follows the style guidelines of this project

  • I have checked for/fixed spelling, linting, and other errors

  • I have commented my code for clarity

  • I have made corresponding changes to the documentation (updating the doc strings in the code is sufficient)

  • My changes generate no new warnings

  • I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:

    • Local testing
    • E2E testing in Teams
  • New and existing unit tests pass locally with my changes

@lilyydu lilyydu changed the title [PY] fix: streaming - citations DO NOT MERGE [PY] fix: streaming - citations Dec 3, 2024
@lilyydu lilyydu requested a review from heyitsaamir as a code owner December 27, 2024 18:48
@lilyydu lilyydu changed the title DO NOT MERGE [PY] fix: streaming - citations [PY] fix: streaming - citations Dec 27, 2024
@corinagum corinagum merged commit 850c77b into main Jan 7, 2025
14 checks passed
@corinagum corinagum deleted the lilyydu/stream-citations-python branch January 7, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants