[JS] fix: Fixed stuck typing indicator issue #2286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stevenic
requested review from
aacebo,
corinagum,
lilyydu,
singhk97,
rajan-chari and
heyitsaamir
as code owners
lilyydu
approved these changes
Jan 29, 2025
corinagum
approved these changes
Jan 30, 2025
corinagum
added a commit
that referenced
this pull request
Feb 4, 2025
## Linked issues closes: #minor ## Details Release for JS 1.7.3 ## What's Changed * [JS] fix: local debug environment variables location in teams chef bot sample by @tecton in #2240 * [JS] bump: (deps): Bump undici from 6.21.0 to 6.21.1 in /js by @dependabot in #2274 * [JS] bump: (deps): Bump the production group across 1 directory with 3 updates by @dependabot in #2270 * [JS] bump: (deps-dev): Bump the development group across 1 directory with 2 updates by @dependabot in #2271 * [repo] bump: (deps): Bump the production group across 1 directory with 5 updates by @dependabot in #2272 * [repo] bump: (deps): Bump the production group with 2 updates by @dependabot in #2281 * [JS] fix: Fixed stuck typing indicator issue by @Stevenic in #2286 * Upgrade OYD endpoint api-version for supporting managed identity in embedding cases by @farhad-shakerin in #2287 * [repo] bump: (deps): Bump the production group with 3 updates by @dependabot in #2289 * [JS] bump: (deps-dev): Bump the development group in /js with 2 updates by @dependabot in #2288 Co-authored-by: Corina Gum <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issues
closes: #2285
Details
The stuck typing indicator appears to occur when we send a
messageactivity while we're in the middle of sending atypingactivity. The fix is to delay the outgoingmessageactivity until after we finish sending thetypingactivity.Change details
Attestation Checklist
My code follows the style guidelines of this project
I have checked for/fixed spelling, linting, and other errors
I have commented my code for clarity
I have made corresponding changes to the documentation (updating the doc strings in the code is sufficient)
My changes generate no new warnings
I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:
New and existing unit tests pass locally with my changes