Skip to content

Commit

Permalink
propsheet: add a CodeQL supression comment (#18431)
Browse files Browse the repository at this point in the history
CodeQL is raising errors when building Visual Studio since they have a
dependency on Windows Terminal for our integrated terminal. The issue
raised by CodeQL refers to a non-constant string format, but in this
case the string comes from a resource file and should be considered
constant.
  • Loading branch information
javierdlg authored Jan 15, 2025
1 parent 8ddb14b commit 25392ea
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/propsheet/console.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ void SaveConsoleSettingsIfNeeded(const HWND hwnd)
LoadStringW(ghInstance, IDS_LINKERROR, awchBuffer, ARRAYSIZE(awchBuffer));
StringCchPrintf(szMessage,
ARRAYSIZE(szMessage),
awchBuffer,
awchBuffer, // CodeQL [SM01734] Pulled from a resource file and cannot be a string literal
gpStateInfo->LinkTitle);
LoadStringW(ghInstance, IDS_LINKERRCAP, awchBuffer, ARRAYSIZE(awchBuffer));

Expand Down

0 comments on commit 25392ea

Please sign in to comment.