Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'closeWindow' ignoring confirmation #18434

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix 'closeWindow' ignoring confirmation #18434

wants to merge 1 commit into from
+1 −9

Conversation

carlos-zamora
Copy link
Member

Summary of the Pull Request

Reroutes the closeWindow action to use the CloseWindow() method like the window's X button does. This includes logic to display the confirmation dialog.

Also removes CloseRequested as it was only used by this action handler. We already have CloseWindowRequested so we're just using that instead.

Validation Steps Performed

✅ closeWindow action while multiple tabs opened brings up the confirmation dialog

PR Checklist

Closes #17613

@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. zBugBash-Consider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows Terminal Alt+F4 behaviour
1 participant
@carlos-zamora