Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fmt] update to 11.0.2 #39738

Merged
merged 49 commits into from
Aug 3, 2024
Merged

[fmt] update to 11.0.2 #39738

merged 49 commits into from
Aug 3, 2024

Conversation

miyanyan
Copy link
Contributor

@miyanyan miyanyan commented Jul 7, 2024

Fixes #40000

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@dg0yt dg0yt mentioned this pull request Jul 7, 2024
7 tasks
@miyanyan
Copy link
Contributor Author

miyanyan commented Jul 7, 2024

got some error with folly, this's my first time to see such error, will see it tomorrow evening

CMake Error in CMakeLists.txt:
Evaluation file to be written multiple times with different content. This
is generally caused by the content evaluating the configuration type,
language, or location of object files:
D:/github/miyanyan/vcpkg/buildtrees/folly/x64-windows-rel/libfolly.pc

libfolly.pc:

  exec_prefix=D:/github/miyanyan/vcpkg/packages/folly_x64-windows
  libdir=${exec_prefix}/lib
  includedir=${prefix}/include
  
  Name: libfolly
  Description: Facebook (Folly) C++ library
  Version: 0.58.0-dev
  Cflags: -I${includedir}  /Zc:__cplusplus  -DFMT_SHARED -DBOOST_CONTEXT_NO_LIB= -DBOOST_CONTEXT_DYN_LINK= -DBOOST_CONTEXT_EXPORT=EXPORT -DBOOST_FILESYSTEM_NO_LIB -DBOOST_FILESYSTEM_DYN_LINK=1 -D -DBOOST_PROGRAM_OPTIONS_NO_LIB -DBOOST_PROGRAM_OPTIONS_DYN_LINK -DBOOST_THREAD_NO_LIB -DBOOST_THREAD_DYN_LINK -DBOOST_THREAD_USE_DLL -DGLOG_USE_GLOG_EXPORT -DGLOG_USE_GFLAGS -DGLOG_NO_ABBREVIATED_SEVERITIES -DGFLAGS_IS_A_DLL=1 -ID:/github/miyanyan/vcpkg/installed/x64-windows/include
  Libs: -L${libdir} -lfolly
  Libs.private: -lIphlpapi.lib -lWs2_32.lib -lD:/github/miyanyan/vcpkg/installed/x64-windows/lib/zlib.lib -l -lD:/github/miyanyan/vcpkg/installed/x64-windows/lib/libssl.lib -l -lD:/github/miyanyan/vcpkg/installed/x64-windows/lib/libcrypto.lib -l

@jimwang118 jimwang118 added the category:port-update The issue is with a library, which is requesting update new revision label Jul 8, 2024
@jimwang118
Copy link
Contributor

got some error with folly, this's my first time to see such error, will see it tomorrow evening

CMake Error in CMakeLists.txt:
Evaluation file to be written multiple times with different content. This
is generally caused by the content evaluating the configuration type,
language, or location of object files:
D:/github/miyanyan/vcpkg/buildtrees/folly/x64-windows-rel/libfolly.pc

libfolly.pc:

  exec_prefix=D:/github/miyanyan/vcpkg/packages/folly_x64-windows
  libdir=${exec_prefix}/lib
  includedir=${prefix}/include
  
  Name: libfolly
  Description: Facebook (Folly) C++ library
  Version: 0.58.0-dev
  Cflags: -I${includedir}  /Zc:__cplusplus  -DFMT_SHARED -DBOOST_CONTEXT_NO_LIB= -DBOOST_CONTEXT_DYN_LINK= -DBOOST_CONTEXT_EXPORT=EXPORT -DBOOST_FILESYSTEM_NO_LIB -DBOOST_FILESYSTEM_DYN_LINK=1 -D -DBOOST_PROGRAM_OPTIONS_NO_LIB -DBOOST_PROGRAM_OPTIONS_DYN_LINK -DBOOST_THREAD_NO_LIB -DBOOST_THREAD_DYN_LINK -DBOOST_THREAD_USE_DLL -DGLOG_USE_GLOG_EXPORT -DGLOG_USE_GFLAGS -DGLOG_NO_ABBREVIATED_SEVERITIES -DGFLAGS_IS_A_DLL=1 -ID:/github/miyanyan/vcpkg/installed/x64-windows/include
  Libs: -L${libdir} -lfolly
  Libs.private: -lIphlpapi.lib -lWs2_32.lib -lD:/github/miyanyan/vcpkg/installed/x64-windows/lib/zlib.lib -l -lD:/github/miyanyan/vcpkg/installed/x64-windows/lib/libssl.lib -l -lD:/github/miyanyan/vcpkg/installed/x64-windows/lib/libcrypto.lib -l

This may be caused by multi-threaded compilation. You can add the DISABLE_PARALLEL_CONFIGURE compilation option and then try compiling.

@WangWeiLin-MV WangWeiLin-MV linked an issue Jul 8, 2024 that may be closed by this pull request
@dg0yt
Copy link
Contributor

dg0yt commented Jul 8, 2024

This may be caused by multi-threaded compilation. ... DISABLE_PARALLEL_CONFIGURE.

This option is for not disabling parallel configuration (i.e. CMake). This helps with parallel writes to the source directory (D:/github/miyanyan/vcpkg/buildtrees/folly/src/...).
However, the error points at the build dir (D:/github/miyanyan/vcpkg/buildtrees/folly/x64-windows-rel/libfolly.pc).

@miyanyan
Copy link
Contributor Author

miyanyan commented Jul 8, 2024

This may be caused by multi-threaded compilation. ... DISABLE_PARALLEL_CONFIGURE.

This option is for not disabling parallel configuration (i.e. CMake). This helps with parallel writes to the source directory (D:/github/miyanyan/vcpkg/buildtrees/folly/src/...). However, the error points at the build dir (D:/github/miyanyan/vcpkg/buildtrees/folly/x64-windows-rel/libfolly.pc).

find an issue facebook/folly#2250

@FrankXie05 FrankXie05 mentioned this pull request Jul 11, 2024
7 tasks
@miyanyan miyanyan changed the title [fmt] update to 11.0.1 [fmt] update to 11.0.2 Jul 21, 2024
@yurybura yurybura mentioned this pull request Jul 22, 2024
7 tasks
@miyanyan
Copy link
Contributor Author

facebook/folly#2265

@jimwang118
Copy link
Contributor

All features passed with following triplets:

x64-windows
x64-windows-static

Usage test pass with following triplets:

x64-windows
x64-windows-static

@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Jul 25, 2024
@miyanyan
Copy link
Contributor Author

facebook/folly#2265

@jimwang118 my folly patch is based on facebook/folly#2255, but seems facebook/folly#2265 is the chosen one, maybe this pr should not merged now?

@jimwang118 jimwang118 removed the info:reviewed Pull Request changes follow basic guidelines label Jul 25, 2024
@jimwang118
Copy link
Contributor

@jimwang118 my folly patch is based on facebook/folly#2255, but seems facebook/folly#2265 is the chosen one, maybe this pr should not merged now?

Okay, I have removed the reviewed tag. Maybe you can use vcpkg_download_distfile to directly download this PR as a patch.

@jimwang118
Copy link
Contributor

I will change the PR status to Draft. If you have finished editing, please click 'ready for review'.

@jimwang118 jimwang118 marked this pull request as draft July 26, 2024 02:17
@miyanyan miyanyan marked this pull request as ready for review August 2, 2024 00:58
@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Aug 2, 2024
@BillyONeal
Copy link
Member

BillyONeal commented Aug 2, 2024

Fixes #40000

Ooooo nice number. Thanks for the updates!

@miyanyan
Copy link
Contributor Author

miyanyan commented Aug 3, 2024

hi, if vcpkg_cmake_configure set BUILD_SHARED_LIBS according to the value of VCPKG_LIBRARY_LINKAGE, is it still needed to replace FMT_SHARED? I found fmt will set it:
https://github.com/fmtlib/fmt/blob/master/CMakeLists.txt#L349

@dg0yt
Copy link
Contributor

dg0yt commented Aug 3, 2024

If you refer to the vcpkg_replace_string: This is needed for projects which don't use CMake. Mostly msbuild.

@BillyONeal
Copy link
Member

What dg0yt said. In general we prefer to rely on build system bindings for as little as possible as not every downstream build system listens to such bindings. That's why this replacement was in place before.

@BillyONeal BillyONeal merged commit fe1cde6 into microsoft:master Aug 3, 2024
16 checks passed
@miyanyan miyanyan deleted the fmt-11.0.1 branch August 23, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fmt] update to 11.0.2 [fmt] update to <11.0.0>
4 participants