Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Content Exclusion for Copilot Hover #13143

Merged
merged 16 commits into from
Jan 16, 2025
Merged

Support Content Exclusion for Copilot Hover #13143

merged 16 commits into from
Jan 16, 2025

Conversation

spebl
Copy link
Contributor

@spebl spebl commented Jan 13, 2025

Get the files used for the context generation and bail before calling the LM if they're excluded.

@spebl spebl requested a review from a team as a code owner January 13, 2025 21:41
@spebl spebl added the Feature: Copilot Hover GitHub Copilot hover "Generate Copilot summary" feature label Jan 13, 2025
Copy link
Contributor

@sean-mcmanus sean-mcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the feature be enabled now? I thought this was the only blocking issue?

@spebl
Copy link
Contributor Author

spebl commented Jan 13, 2025

Should the feature be enabled now? I thought this was the only blocking issue?

We're still waiting for final sign-off before rolling it out. @benmcmorran has been tracking the privacy approval which is the last step.

@benmcmorran
Copy link
Member

@sean-mcmanus Not sure exactly when you were planning to do the 1.23 official release, but assuming we get the approval from the VS Code team to use the proposed API soon, is it feasible to ensure this PR makes it into the release? That will put us in a position to enable for the GA audience once all sign-offs are complete.

@benmcmorran
Copy link
Member

Discussed offline with @Colengms and it sounds like that timeline may not be feasible. It's fine to hold this for the next insiders release instead.

sean-mcmanus

This comment was marked as resolved.

@spebl
Copy link
Contributor Author

spebl commented Jan 15, 2025

Did the SSH build fail from these changes or is that some unrelated issue?

These changes, about to push an update.

sean-mcmanus
sean-mcmanus previously approved these changes Jan 15, 2025
@spebl spebl merged commit 5d32121 into main Jan 16, 2025
6 checks passed
@spebl spebl deleted the dev/spebl/content_ex branch January 16, 2025 20:13
@sean-mcmanus sean-mcmanus added this to the 1.24.0 milestone Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Copilot Hover GitHub Copilot hover "Generate Copilot summary" feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants