test framework traits for Chat #13285
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukka
changed the title
| @@ -235,7 +235,10 @@ export class CppConfigurationLanguageModelTool implements vscode.LanguageModelTo | |||
| contextString += `The project targets the ${chatContext.targetArchitecture} architecture. `; | |||
| telemetryProperties["targetArchitecture"] = chatContext.targetArchitecture; | |||
| } | |||
|
|
|||
| if (chatContext.usedTestFrameworks?.length > 0) { | |||
There was a problem hiding this comment.
I don't think ?. is needed, right? It's not used for the other members and it seems like it would always be defined.
lukka
force-pushed
the
dev/lukka/test-framework-for-chat
branch
from
828bec8 to
68bf625
Compare
| @@ -154,7 +154,8 @@ describe('CppConfigurationLanguageModelTool Tests', () => { | |||
| standardVersion: 'c++20', | |||
| compiler: 'msvc', | |||
| targetPlatform: 'windows', | |||
| targetArchitecture: 'x64' | |||
| targetArchitecture: 'x64', | |||
| usedTestFrameworks: ['gtest', 'catch2'] | |||
There was a problem hiding this comment.
Should these actually match the casing of what we send? e.g. "GTest", "Catch2"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.