Skip to content

Commit

Permalink
Bump upload/download actions (#16412)
Browse files Browse the repository at this point in the history
  • Loading branch information
DonJayamanne authored Jan 31, 2025
1 parent ca8fbea commit e7adaba
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/aggregate-test-results.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
run: python ./pythonFiles/aggregateTestResults.py ${{ secrets.GITHUB_TOKEN }} ${{ inputs.collection_date }}

- name: Upload test result files
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: testResults-${{ inputs.collection_date }}
path: AggTestResults-*.json
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ jobs:
uses: ./.github/actions/build-vsix
id: build-vsix

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: 'ms-toolsai-jupyter-insiders.vsix'
path: 'ms-toolsai-jupyter-insiders.vsix'
Expand Down Expand Up @@ -748,7 +748,7 @@ jobs:
if: matrix.python == 'noPython' && matrix.os != 'windows-latest'

- name: Upload VS code logs
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: failure()
with:
name: VSCodeLogs-${{matrix.jupyterConnection}}-${{matrix.python}}-${{matrix.pythonVersion}}-${{matrix.packageVersion}}-${{matrix.os}}-${{env.TAGS_NAME}}-${{matrix.ipywidgetsVersion}}
Expand All @@ -760,7 +760,7 @@ jobs:
run: npm run printTestResults

- name: Upload test result, screenshots files
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: always()
with:
name: TestLogs-${{matrix.jupyterConnection}}-${{matrix.python}}-${{matrix.pythonVersion}}-${{matrix.packageVersion}}-${{matrix.os}}-${{env.TAGS_NAME}}-${{matrix.ipywidgetsVersion}}
Expand Down Expand Up @@ -807,7 +807,7 @@ jobs:
run: npm i -g npm@${{env.NPM_VERSION}}

- name: Download VSIX
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: 'ms-toolsai-jupyter-insiders.vsix'

Expand Down

0 comments on commit e7adaba

Please sign in to comment.