Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move notebook debugger into notebook folder #10038

Merged
merged 2 commits into from
May 16, 2022
Merged

Conversation

DonJayamanne
Copy link
Contributor

@DonJayamanne DonJayamanne commented May 16, 2022

Part of #10037

The plan is to have the following folder structure:
src->platform->debugger->jupyter->notebook (specific to notebook debugging)
src->platform->debugger->jupyter->interactiveWindow (specific to IW debugging)
src->platform->debugger->jupyter->common (Stuff thats common to both will eventually move into this folder)

@DonJayamanne DonJayamanne requested a review from a team as a code owner May 16, 2022 04:27
@codecov-commenter
Copy link

Codecov Report

Merging #10038 (91c5acf) into main (1a06230) will increase coverage by 0%.
The diff coverage is 76%.

@@          Coverage Diff           @@
##            main   #10038   +/-   ##
======================================
  Coverage     63%      63%           
======================================
  Files        215      216    +1     
  Lines      10122    10127    +5     
  Branches    1612     1612           
======================================
+ Hits        6473     6480    +7     
+ Misses      3131     3125    -6     
- Partials     518      522    +4     
Impacted Files Coverage Δ
...gger/jupyter/notebook/debugCellControllers.node.ts 25% <25%> (ø)
src/platform/debugger/jupyter/helper.node.ts 54% <100%> (+2%) ⬆️
...atform/debugger/jupyter/kernelDebugAdapter.node.ts 69% <100%> (ø)
...debugger/jupyter/notebook/debuggingManager.node.ts 53% <100%> (ø)
...ugger/jupyter/notebook/runByLineController.node.ts 66% <100%> (ø)
src/platform/serviceRegistry.node.ts 97% <100%> (ø)
src/platform/errors/errorHandler.ts 62% <0%> (-1%) ⬇️
...rc/platform/common/dataScienceSurveyBanner.node.ts 69% <0%> (+3%) ⬆️

Copy link
Contributor

@sadasant sadasant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it! Short & well scoped ✅

@DonJayamanne DonJayamanne merged commit 2d424d1 into main May 16, 2022
@DonJayamanne DonJayamanne deleted the moveIntoNotebookFolder branch May 16, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants