Fix reading JUPYTER_RUNTIME_DIR and XDG_RUNTIME_DIR
#16451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathew Wicks <[email protected]>
2 tasks
bpasero
approved these changes
Feb 18, 2025
DonJayamanne
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16450
Currently, we don't respect either
JUPYTER_RUNTIME_DIRorXDG_RUNTIME_DIRwhen determining where to store our runtime files.This PR simply fixes a typo that was preventing us from reading
XDG_RUNTIME_DIRand also makes it so that we readJUPYTER_RUNTIME_DIR(the official config for this in Jupyter itself) before falling back toXDG_RUNTIME_DIR.