Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support middleman v5 #35

Merged
merged 5 commits into from
Aug 16, 2020
Merged

Support middleman v5 #35

merged 5 commits into from
Aug 16, 2020

Conversation

le0pard
Copy link
Contributor

@le0pard le0pard commented Aug 14, 2020

No description provided.

@le0pard
Copy link
Contributor Author

le0pard commented Aug 14, 2020

Should also close #21

@tdreyno
Copy link
Member

tdreyno commented Aug 14, 2020

This is really great, thank you.

I am curious, what is the goal of using an options hash over the old option approach for the compress items? If possible, I'd love to avoid breaking API compatibility with v4 config files.

@le0pard
Copy link
Contributor Author

le0pard commented Aug 14, 2020

@tdreyno thanks for feedback.

I moved its to separate config key, because thinking not to mix with additional options, like already added ignore and content_types (and maybe some future general options).

I can back all configuration on one level, it is not an issue (maybe just need little more logic to remove general settings from config before pass its to HtmlCompressor).

Just confirm, that this looks good for configuration to move all on one level :)

@tdreyno
Copy link
Member

tdreyno commented Aug 15, 2020

Confirmed. Lets go back to one level so this doesn't break existing configs. Then 👍

@le0pard
Copy link
Contributor Author

le0pard commented Aug 15, 2020

Done. Please check @tdreyno

@tdreyno tdreyno merged commit 6808039 into middleman:master Aug 16, 2020
@le0pard le0pard deleted the v5-support branch August 16, 2020 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants