skip collection of attempts when maxAttempts is Infinity #312
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential issue in a scenario of retryCount = -1
In the scenario that an app instance can acquire to the lock while other instances wait for the lock, the
attempts
array will keep collectingstats
as long as theroutine()
is still on hold. E.g. the app instance subscribes to external service for a regular polling may want to hold the lock forever until an error occurs or the app instance is down. That would eventually be a memory-leak issue in other app instances who wait for the lock, because each retry failed to obtain the lock =>attempts
array will collect 1stats
.So in this scenario, there should be either a maximum limit for
attempts
to collect thestats
, or may just skip the collection.