Semgrep pre-commit hook #241
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kantord
reviewed
Dec 19, 2024
Co-authored-by: Dániel Kántor <[email protected]>
peppescg
force-pushed
the
semgrep_secrets_scanning
branch
from
5a760b4 to
b4a51d2
Compare
evankanderson
approved these changes
Jan 10, 2025
Comment on lines
+30
to
+31
| import future.keywords.if | ||
| import future.keywords.every |
There was a problem hiding this comment.
I think import rego.v1 brings you both of these.
Suggested change
| import future.keywords.if | |
| import future.keywords.every | |
| import rego.v1 |
| semgrep_hooks[hook_id].id == "semgrep" | ||
| } | ||
|
|
||
| message := "" if allow |
There was a problem hiding this comment.
I believe message is only used when allow is false, so you can just do:
Suggested change
| message := "" if allow | |
| message := "Semgrep pre-commit hook is not configured for the repository" |
| repo_data := parsed_data.repos[repo_id] | ||
| endswith(repo_data["repo"], "https://github.com/semgrep/pre-commit") | ||
| semgrep_hooks = repo_data["hooks"] | ||
| semgrep_hooks[hook_id].id == "semgrep" |
There was a problem hiding this comment.
It looks like Semgrep has 4 configurations: semgrep, semgrep-ci, semgrep-docker, and semgrep-docker-develop. It looks like this requires the semgrep one and not (for example) the CI one. Is this usage intentional?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.