Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for onboarding data-platform users #2944

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

shaidar
Copy link
Contributor

@shaidar shaidar commented Feb 6, 2025

What are the relevant tickets?

#2933

Description (What does it do?)

Performs all the manual changes I've made on CI when working on the onboarding flow of new users. One caveat is that Organizations aren't yet supported in the Pulumi Keycloak provider, and so will require manual intervention initially.

@shaidar shaidar force-pushed the sar/issue_2933 branch 2 times, most recently from 7100b9a to 97b4129 Compare February 25, 2025 19:02
@shaidar
Copy link
Contributor Author

shaidar commented Feb 28, 2025

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces changes to the Keycloak configuration, including enabling organization features, updating themes, configuring passwordless authentication, and defining roles and client scopes for the OL Data platform. These changes aim to streamline the onboarding process for new data platform users. The addition of passwordless authentication and role-based access control are significant improvements.

Merge Readiness

The changes introduced in this pull request appear to be well-structured and address the stated objective of streamlining the onboarding process for data platform users. However, due to the complexity of the changes and the lack of specific testing information, I am unable to fully assess the readiness for merging. I recommend that the author provide additional details on the testing performed, particularly around the new passwordless authentication flow and role-based access control configurations. I am unable to approve this pull request, and recommend that others review and approve this code before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants