-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
posthog for learn-ai #2997
base: main
Are you sure you want to change the base?
posthog for learn-ai #2997
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @mbertrand, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request configures PostHog for the learn-ai application. It sets the necessary environment variables for both the production and QA environments. The production environment will use the same PostHog project as mit-learn RC and prod, while the QA environment will use a separate project with session recording enabled. Additionally, it adds GitHub Actions variables for PostHog API keys.
Highlights
- PostHog Configuration: The PR configures PostHog for learn-ai, enabling analytics and session recording.
- Environment Variables: It sets environment variables for PostHog API host, project ID, timeout, and session recording in both production and QA environments.
- GitHub Actions Variables: It adds GitHub Actions variables for PostHog project and personal API keys.
Changelog
- src/ol_infrastructure/applications/learn_ai/Pulumi.applications.learn_ai.Production.yaml
- Added PostHog environment variables: POSTHOG_API_HOST, POSTHOG_ENABLED, POSTHOG_PROJECT_ID, POSTHOG_TIMEOUT_MS, and POSTHOG_ENABLE_SESSION_RECORDING.
- The POSTHOG_PROJECT_ID is set to 63497.
- src/ol_infrastructure/applications/learn_ai/Pulumi.applications.learn_ai.QA.yaml
- Added PostHog environment variables: POSTHOG_API_HOST, POSTHOG_ENABLED, POSTHOG_PROJECT_ID, POSTHOG_TIMEOUT_MS, and POSTHOG_ENABLE_SESSION_RECORDING.
- The POSTHOG_PROJECT_ID is set to 86325, and POSTHOG_ENABLE_SESSION_RECORDING is set to "true".
- src/ol_infrastructure/applications/learn_ai/main.py
- Added GitHub Actions variables for POSTHOG_PROJECT_API_KEY and POSTHOG_PERSONAL_API_KEY.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
The logs flow, data streams,
PostHog watches, fulfilling dreams.
Insights gleaned, funnels defined,
User behavior, now aligned.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request introduces PostHog integration for the learn-ai application and sets up GitHub Actions variables for PostHog API keys. The changes look good overall, but there are a few minor points to consider.
Merge Readiness
The changes seem reasonable and straightforward. I don't see any immediate issues that would block merging. However, it would be beneficial to double-check the PostHog project IDs and ensure they are correct for each environment. I am unable to directly approve this pull request, and recommend that others review and approve this code before merging.
45c893c
to
d594e30
Compare
d594e30
to
ec992aa
Compare
What are the relevant tickets?
N/A
Description (What does it do?)
Sets posthog env's for learn-ai; should use the same project as mit-learn RC and prod.
How can this be tested?
N/A