Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update migration guide for #1205 #1211

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

qinsoon
Copy link
Member

@qinsoon qinsoon commented Sep 27, 2024

No description provided.

@qinsoon
Copy link
Member Author

qinsoon commented Sep 27, 2024

binding-refs
JULIA_BINDING_REPO=qinsoon/mmtk-julia
JULIA_BINDING_REF=update-mmtk-core-1205

@qinsoon qinsoon added the PR-extended-testing Run extended tests for the pull request label Sep 27, 2024
Copy link
Collaborator

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an obvious typo. Good otherwise.

docs/userguide/src/migration/prefix.md Outdated Show resolved Hide resolved
@qinsoon qinsoon mentioned this pull request Sep 27, 2024
Copy link
Collaborator

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinsoon qinsoon added this pull request to the merge queue Sep 27, 2024
Merged via the queue into mmtk:master with commit de10fa4 Sep 27, 2024
34 checks passed
@qinsoon qinsoon deleted the update-migration-guide-1205 branch September 27, 2024 05:32
github-merge-queue bot pushed a commit that referenced this pull request Sep 27, 2024
Merge this PR after #1208 and
#1211.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-extended-testing Run extended tests for the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants