Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make env_logger an optional dependency #1226

Merged
merged 5 commits into from
Nov 6, 2024

Commits on Nov 5, 2024

  1. Make env_logger an optional dependency

    Now the built-in env_logger is guarded behind a Cargo feature
    "builtin_env_logger".  It is a default feature, but can be disabled
    in Cargo.toml by setting `dependencies.mmtk.default-features = false`.
    In this way, VM bindings that want to implement its own logger can
    remove the env_logger crate from its dependencies.
    wks committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    86ce270 View commit details
    Browse the repository at this point in the history
  2. Update error handling

    wks committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    7fe1407 View commit details
    Browse the repository at this point in the history
  3. Make try_init pub(crate)

    wks committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    17e6441 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Move error checking into logger::try_init

    memory_manager::mmtk_init simply calls `try_init()` now.
    wks committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    6967a58 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d3ebf5a View commit details
    Browse the repository at this point in the history