Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nightly build and add inline attributes to {un,}likely #1228

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Fix nightly build and add inline attributes to {un,}likely #1228

merged 2 commits into from
Nov 7, 2024

Conversation

k-sareen
Copy link
Collaborator

@k-sareen k-sareen commented Nov 6, 2024

No description provided.

@k-sareen
Copy link
Collaborator Author

k-sareen commented Nov 6, 2024

I re-added the inline attributes to {un,}likely to make them consistent with where we copied them from.

@k-sareen k-sareen requested a review from wks November 6, 2024 23:44
wks
wks approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k-sareen k-sareen added this pull request to the merge queue Nov 7, 2024
Merged via the queue into mmtk:master with commit 41501a5 Nov 7, 2024
33 checks passed
@k-sareen k-sareen deleted the k-sareen-patch-1 branch November 7, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wks wks wks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-sareen @wks