-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ExternalPageResource and allow discontiguous VM space #864
Conversation
Currently we cannot run with MSRV 1.61 at the moment. We have a dependency chain |
From rust-cli/env_logger#273, the options for us are:
I would suggest 2. It does not look like cargo/Rust will improve on this any time soon, and 2 does no harm. |
We can also play our old trick of locking a dependency to a specific version until the problem is solved. We once did this for diff --git a/Cargo.toml b/Cargo.toml
index db4da419d..6f07eb851 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -28,6 +28,7 @@ delegate = "0.9.0"
downcast-rs = "1.1.1"
enum-map = "2.4.2"
env_logger = "0.10.0"
+is-terminal = "=0.4.7" # latest version requires MSRV 1.63
itertools = "0.10.5"
jemalloc-sys = { version = "0.5.3", features = ["disable_initial_exec_tls"], optional = true }
lazy_static = "1.1" |
8e06b28
to
7d19f58
Compare
7d19f58
to
7fc052e
Compare
Co-authored-by: Kunal Sareen <[email protected]>
binding-refs |
This PR is ready for review again. @wks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR changes
VMSpace
to multiple discontiguous regions as VM space. This PR is used in mmtk/mmtk-julia#71 to support system and package images.ExternalPageResource
to manage the discontiguous regions.VMSpace
withExternalPageResource
.VMSpace
no longer usesImmortalSpace
.lazy_init_vm_space
toset_vm_space
, as we allow setting vm space multiple times with non overlapping regions.