Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Allocators type to public API #880

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

playXE
Copy link
Contributor

@playXE playXE commented Aug 1, 2023

Without it getting offsets of Allocators fields is impossible in Rust, other bindings just declare that type in header file but in Rust it should be as simple as using memoffset crate + Allocators type from mmtk-core itself.

Copy link
Member

@qinsoon qinsoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinsoon qinsoon merged commit 7552deb into mmtk:master Aug 2, 2023
13 of 14 checks passed
@qinsoon qinsoon mentioned this pull request Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants