Skip to content

Commit

Permalink
Fix some codacy issues.
Browse files Browse the repository at this point in the history
  • Loading branch information
mnlipp committed Mar 3, 2025
1 parent eb3979d commit 17e2a7c
Show file tree
Hide file tree
Showing 8 changed files with 47 additions and 7 deletions.
38 changes: 38 additions & 0 deletions .markdownlint.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
# See https://github.com/DavidAnson/markdownlint/blob/main/schema/.markdownlint.yaml

# Default state for all rules
default: true

# MD007/ul-indent : Unordered list indentation :
# https://github.com/DavidAnson/markdownlint/blob/v0.37.4/doc/md007.md
MD007:
# Spaces for indent
indent: 2
# Whether to indent the first level of the list
start_indented: true
# Spaces for first level indent (when start_indented is set)
start_indent: 2

# MD025/single-title/single-h1 : Multiple top-level headings in the same document :
# https://github.com/DavidAnson/markdownlint/blob/v0.37.4/doc/md025.md
MD025:
# Heading level
level: 1
# RegExp for matching title in front matter (disable)
front_matter_title: ""

# MD036/no-emphasis-as-heading : Emphasis used instead of a heading :
# https://github.com/DavidAnson/markdownlint/blob/v0.37.4/doc/md036.md
MD036: false

# MD043/required-headings : Required heading structure :
# https://github.com/DavidAnson/markdownlint/blob/v0.37.4/doc/md043.md
MD043:
# List of headings
headings: [
"# Head",
"## Item",
"### Detail"
]
# Match case of headings
match_case: false
2 changes: 1 addition & 1 deletion dev-example/test-vm.tpl.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ spec:
# repository: ghcr.io
# path: mnlipp/org.jdrupes.vmoperator.runner.qemu-alpine
# version: "3.0.0"
source: registry.mnl.de/org/jdrupes/vm-operator/org.jdrupes.vmoperator.runner.qemu-arch:testing
source: registry.mnl.de/org/jdrupes/vm-operator/org.jdrupes.vmoperator.runner.qemu-arch:feature-auto-login
pullPolicy: Always

permissions:
Expand Down
2 changes: 1 addition & 1 deletion org.jdrupes.vmoperator.vmaccess/.eclipse-pmd
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@
<rulesets>
<ruleset name="Custom Rules" ref="VM-Operator/ruleset.xml" refcontext="workspace" />
</rulesets>
</eclipse-pmd>
</eclipse-pmd>
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ public void onConsoleReady(ConsoleReady event, ConsoleConnection channel)
public void onConsoleConfigured(ConsoleConfigured event,
ConsoleConnection connection) throws InterruptedException,
IOException {
@SuppressWarnings("unchecked")
@SuppressWarnings({ "unchecked", "PMD.PrematureDeclaration" })
final var rendered
= (Set<ResourceModel>) connection.session().get(RENDERED);
connection.session().remove(RENDERED);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
span[role="button"].svg-icon {
display: inline-block;
line-height: 1;

/* Align with forkawesome */
font-size: 14px;
fill: var(--primary);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@
span[role="button"].svg-icon {
display: inline-block;
line-height: 1;

/* Align with forkawesome */
font-size: 14px;
fill: var(--primary);
Expand Down
4 changes: 2 additions & 2 deletions webpages/pools.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ The VMs should only be accessible via a desktop started by the VM-Operator.
# systemctl disable gdm
# systemctl stop gdm
```

* Disable `getty` on tty1.

```console
Expand Down Expand Up @@ -55,7 +55,7 @@ The following should actually be configured for any VM.
The VM-Operator agent runs as a systemd service. Sample configuration
files can be found
[here](https://github.com/mnlipp/VM-Operator/tree/main/dev-example/vmop-agent).
Copy
Copy

* `99-vmop-agent.rules` to `/usr/local/lib/udev/rules.d/99-vmop-agent.rules`,
* `vmop-agent` to `/usr/local/libexec/vmop-agent` and
Expand Down
4 changes: 2 additions & 2 deletions webpages/upgrading.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ layout: vm-operator
## To version 4.0.0

* The VmViewer conlet has been renamed to VmAccess. This affects the
[configuration](https://jdrupes.org/vm-operator/user-gui.html).
[configuration](https://jdrupes.org/vm-operator/user-gui.html).
Configuration information using the old path
`/Manager/GuiHttpServer/ConsoleWeblet/WebConsole/ComponentCollector/VmViewer`
is still accepted for backward compatibility until the next major version,
Expand All @@ -24,7 +24,7 @@ layout: vm-operator

* The configuration property `passwordValidity` has been moved from component
`/Manager/Controller/DisplaySecretMonitor` to
`/Manager/Controller/Reconciler/DisplaySecretReconciler`. The old path is
`/Manager/Controller/Reconciler/DisplaySecretReconciler`. The old path is
still accepted for backward compatibility until the next major version,
but should be updated.

Expand Down

0 comments on commit 17e2a7c

Please sign in to comment.