tests: frontend/dockerfile: update integration tests for windows/wcow (part 4) #5253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/dockerfile
area/testing
area/windows
area/frontend
area/util
labels
profnandaa
force-pushed
the
tests-4485-part-2
branch
3 times, most recently
from
129b223
to
e5c31e0
Compare
Additional translated tests for Windows in frontend/dockerfile. - [x] `testDockerfileDirs` - [x] `testDockerfileInvalidCommand` - [x] `testCopyUnicodePath` - [x] `testHistoryError` - [x] `testTargetsDescribeDefinition` - [x] `testHistoryFinalizeTrace` - [x] `testOutlineDescribeDefinition` - [x] `testCopyRelative` - [x] `testNamedLocalContext` - [x] `testLocalCustomSessionID` - [x] `testNamedOCILayoutContextExport` - [x] `testSourcePolicyWithNamedContext` Signed-off-by: Anthony Nandaa <[email protected]>
profnandaa
force-pushed
the
tests-4485-part-2
branch
from
e5c31e0
to
13fefce
Compare
profnandaa
changed the title
profnandaa
changed the title
tonistiigi
reviewed
Aug 16, 2024
| `) | ||
| `, | ||
| ` | ||
| FROM nanoserver |
There was a problem hiding this comment.
Out of scope for this PR: Is the FROM scratch not working at all in windows? I think in buildkit we should make it work. It should fail if you need to create image/container on top of FROM scratch stage, but if you just use docker buildx build -o out --target=binaries . then that should work in windows as well just to get the artifacts without base image.
There was a problem hiding this comment.
ok, opened a tracking issue here - #5264
tonistiigi
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional translated tests for Windows in frontend/dockerfile.
testDockerfileDirstestDockerfileInvalidCommandtestCopyUnicodePathtestHistoryErrortestTargetsDescribeDefinitiontestHistoryFinalizeTracetestOutlineDescribeDefinitiontestCopyRelativetestNamedLocalContexttestLocalCustomSessionIDtestNamedOCILayoutContextExporttestSourcePolicyWithNamedContexttestSourcePolicyWithNamedContextPartially addresses #4485