Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replaces params array with params ReadOnlySpan #2125

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

kamronbatman
Copy link
Contributor

@kamronbatman kamronbatman commented Feb 14, 2025

Summary

If you don't need to use the array built by params, then changing params T[] to params ReadOnlySpan<T> will hint to the compiler to make a global static array and to not allocate the input as an array.

@kamronbatman kamronbatman merged commit 279b10d into main Feb 14, 2025
11 of 12 checks passed
@kamronbatman kamronbatman deleted the kbatman/use_readonly_span branch February 14, 2025 05:19
Copy link

Qodana for .NET

11 new problems were found

Inspection name Severity Problems
Possible 'System.InvalidCastException' in foreach loop 🔶 Warning 6
Replace 'switch' statement with 'switch' expression 🔶 Warning 1
Specify string culture explicitly ◽️ Notice 3
Equality comparison of floating point numbers ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Detected 20 dependencies

Third-party software list

This page lists the third-party software dependencies used in ModernUO

Dependency Version Licenses
Argon2.Bindings 1.16.1 MIT
BouncyCastle.Cryptography 2.5.0 MIT
CommunityToolkit.HighPerformance 8.4.0 MIT
LibDeflate.Bindings 1.0.2.120 GPL-3.0-only
MailKit 4.10.0 MIT
Microsoft.Extensions.FileSystemGlobbing 9.0.2 MIT
MimeKit 4.10.0 MIT
ModernUO.CodeGeneratedEvents.Annotations 1.0.0 GPL-3.0-only
ModernUO.CodeGeneratedEvents.Generator 1.0.3.2 GPL-3.0-only
ModernUO.Serialization.Annotations 2.9.1 GPL-3.0-only
ModernUO.Serialization.Generator 2.12.20 GPL-3.0-only
Nerdbank.GitVersioning 3.7.115 MIT
PollGroup 1.6.1 BSD-3-Clause
Serilog.Sinks.Async 2.1.0 Apache-2.0
Serilog.Sinks.Console 6.0.0 Apache-2.0
Serilog 4.2.0 Apache-2.0
System.Formats.Asn1 8.0.1 MIT
System.IO.Hashing 9.0.2 MIT
System.Security.Cryptography.Pkcs 8.0.1 MIT
Zstd.Binaries 1.6.0 MIT
Contact Qodana team

Contact us at [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant