Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: useParams() should remove unused keys. #507

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Fix: useParams() should remove unused keys. #507

merged 1 commit into from
Jan 30, 2025

Conversation

molefrog
Copy link
Owner

Closes #478

Copy link

stackblitz bot commented Jan 30, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

size-limit report 📦

Path Size
packages/wouter/esm/index.js 2.38 KB (+0.33% 🔺)
packages/wouter/esm/use-browser-location.js 622 B (0%)
packages/wouter/esm/memory-location.js 798 B (0%)
packages/wouter/esm/use-hash-location.js 733 B (0%)
packages/wouter-preact/esm/index.js 2.27 KB (+0.26% 🔺)
packages/wouter-preact/esm/use-browser-location.js 552 B (0%)
packages/wouter-preact/esm/use-hash-location.js 645 B (0%)
packages/wouter-preact/esm/memory-location.js 702 B (0%)

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e165511) to head (e4a79d4).
Report is 1 commits behind head on v3.

Additional details and impacted files
@@            Coverage Diff            @@
##                v3      #507   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            1         1           
=========================================
  Hits             1         1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kordonme
Copy link

Looks good to me ❤️

@WebBurnout
Copy link

Excellent!!

@molefrog molefrog merged commit 7e6b4d6 into v3 Jan 30, 2025
4 checks passed
@molefrog molefrog deleted the fix/use-params branch January 30, 2025 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useParams do not update when there are no path params
3 participants