Skip to content

Commit

Permalink
fix: do not attempt to publish e2e-tests package (#1659)
Browse files Browse the repository at this point in the history
The publishing step would currently fail on the `e2e-tests` package
because it defined a broken `prepublish` script.

We should not be trying to publish the package at all; mark
it `private`.
  • Loading branch information
addaleax authored Sep 5, 2023
1 parent 3066c8f commit 60053aa
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 3 deletions.
3 changes: 2 additions & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions packages/build/src/npm-packages/publish.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ describe('npm-packages publishNpmPackages', function () {
[
'publish',
'from-package',
'--no-private',
'--no-changelog',
'--no-push',
'--exact',
Expand Down
1 change: 1 addition & 0 deletions packages/build/src/npm-packages/publish.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ export function publishNpmPackages(
[
'publish',
'from-package',
'--no-private',
'--no-changelog',
'--no-push',
'--exact',
Expand Down
2 changes: 1 addition & 1 deletion packages/connectivity-tests/package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "connectivity-tests",
"name": "@mongosh/connectivity-tests",
"version": "0.0.0-dev.0",
"private": true,
"license": "Apache-2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/e2e-tests/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"name": "@mongosh/e2e-tests",
"version": "0.0.0-dev.0",
"private": true,
"description": "MongoDB Shell E2E Tests Package",
"homepage": "https://github.com/mongodb-js/mongosh",
"author": "Compass Team <[email protected]>",
Expand All @@ -16,7 +17,6 @@
"lint": "npm run eslint . && npm run prettier -- --check .",
"check": "npm run lint && npm run depcheck",
"depcheck": "depcheck",
"prepublish": "npm run compile",
"prettier": "prettier",
"reformat": "npm run prettier -- --write . && npm run eslint --fix"
},
Expand Down

0 comments on commit 60053aa

Please sign in to comment.