-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-45053 added tags to hierarchy create cluster page #32
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for docs-atlas-architecture ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add dev/test examples, test to ensure all work
@kyuan-mongodb what is the reason for using the CLI command with parameters for dev and test environments and with JSON file for staging and production? |
@@ -28,6 +28,14 @@ | |||
region_name = var.atlas_region | |||
} | |||
} | |||
tags { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the link in the PR description is incorrect because it's for cluster (which will be deprecated), the correct documentation for advanced_cluster is: https://registry.terraform.io/providers/mongodb/mongodbatlas/latest/docs/resources/advanced_cluster
so tags should be defined as:
tags {
key = "BU"
value = "ConsumerProducts"
}
tags {
key = "TeamName"
value = "TeamA"
}
etc.
same for example below
@kyuan-mongodb apologies if my questions was not clear. What I mean is why do we use command line parameters in one case (dev and test) but we use the |
Hi @mmarcon, we did this both because the dev example was simple enough to do this (while the prod example will eventually be too complex to do without a config file), and to showcase different ways to accomplish this. |
For Terraform, I used this page as a reference.
JIRA
Staging