Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-45053 added tags to hierarchy create cluster page #32

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

kyuan-mongodb
Copy link
Collaborator

@kyuan-mongodb kyuan-mongodb commented Nov 1, 2024

For Terraform, I used this page as a reference.

JIRA
Staging

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for docs-atlas-architecture ready!

Name Link
🔨 Latest commit 31a27cb
🔍 Latest deploy log https://app.netlify.com/sites/docs-atlas-architecture/deploys/672e3c6411b6920008126805
😎 Deploy Preview https://deploy-preview-32--docs-atlas-architecture.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sarahsimpers
Copy link
Collaborator

Hi Kailie, I just tried to test this for the CLI and it didn't work, please see the attached error. Also, we're missing examples for Dev and Test environments. Please add those examples as well (may require changing format for the CLI dev/test to use a cluster config file), and test before resubmitting. Thanks!
Screenshot 2024-11-05 at 7 43 01 AM

Copy link
Collaborator

@sarahsimpers sarahsimpers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add dev/test examples, test to ensure all work

@mmarcon
Copy link
Collaborator

mmarcon commented Nov 8, 2024

@kyuan-mongodb what is the reason for using the CLI command with parameters for dev and test environments and with JSON file for staging and production?

@kyuan-mongodb
Copy link
Collaborator Author

Hi @mmarcon, We're adding in tags because we suggest users to do so higher on the page here.

@@ -28,6 +28,14 @@
region_name = var.atlas_region
}
}
tags {
Copy link
Member

@lantoli lantoli Nov 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the link in the PR description is incorrect because it's for cluster (which will be deprecated), the correct documentation for advanced_cluster is: https://registry.terraform.io/providers/mongodb/mongodbatlas/latest/docs/resources/advanced_cluster

so tags should be defined as:

tags {
  key   = "BU"
  value = "ConsumerProducts"
}
tags {
  key   = "TeamName"
  value = "TeamA"
}

etc.

same for example below

@kyuan-mongodb kyuan-mongodb requested review from lantoli and removed request for Zuhairahmed November 8, 2024 16:29
@mmarcon
Copy link
Collaborator

mmarcon commented Nov 8, 2024

@kyuan-mongodb apologies if my questions was not clear. What I mean is why do we use command line parameters in one case (dev and test) but we use the --file option with a JSON file in the other case (stg and prod)? Why not picking one way and using that for both?

@sarahsimpers
Copy link
Collaborator

@kyuan-mongodb apologies if my questions was not clear. What I mean is why do we use command line parameters in one case (dev and test) but we use the --file option with a JSON file in the other case (stg and prod)? Why not picking one way and using that for both?

Hi @mmarcon, we did this both because the dev example was simple enough to do this (while the prod example will eventually be too complex to do without a config file), and to showcase different ways to accomplish this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants