Feat 📜: add BLS12-381 precompiles #3197
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pLabarta
added
B7-runtimenoteworthy
WASM runtime size check:Compared to target branchMoonbase runtime: 2532 KB (+112 KB) 🚨 Moonbeam runtime: 2512 KB (+104 KB) 🚨 Moonriver runtime: 2512 KB (+100 KB) 🚨 Compared to latest release (runtime-3501)Moonbase runtime: 2532 KB (+580 KB compared to latest release) 🚨 Moonbeam runtime: 2512 KB (+572 KB compared to latest release) 🚨 Moonriver runtime: 2512 KB (+572 KB compared to latest release) 🚨 |
Coverage Report@@ Coverage Diff @@
## master pablo/bls12-381-precompile +/- ##
=============================================================
Coverage 74.51% 74.51% 0.00%
Files 381 381
Lines 96551 96551
=============================================================
Hits 71940 71940
Misses 24611 24611
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds the requires BLS12-381 precompiles as specified by EIP-2537.
Precompiles are available at the following addresses:
What important points should reviewers know?
Since precompiles are imported from
frontierand its tests include all the test vectors detailed in the EIP, this PR does not duplicate those tests. Instead, it only includes one e2e test that calls each precompile from theBLS12381Helper1&BLS12381Helper2contracts and check for the first case in the specified test vectors.Including the precompiles also broke a few tests by causing an small increase in gas costs. Most just had their
inlineSnapshotupdated, but one required extra funding.Is there something left for follow-up PRs?
This PR is a pre-requirement for supporting Ethereum's Pectra upgrade.