Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow usage of full PoV size #3198

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

manuelmauro
Copy link
Contributor

What does it do?

Allow usage of full PoV size.

What important points should reviewers know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@manuelmauro manuelmauro added B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes D2-notlive PR doesn't change runtime code (so can't be audited) labels Feb 24, 2025
@manuelmauro manuelmauro self-assigned this Feb 24, 2025
Copy link
Contributor

github-actions bot commented Feb 24, 2025

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2420 KB (no changes) 🚨

Moonbeam runtime: 2408 KB (no changes) 🚨

Moonriver runtime: 2400 KB (-12 KB) ✅

Compared to latest release (runtime-3501)

Moonbase runtime: 2420 KB (+468 KB compared to latest release) 🚨

Moonbeam runtime: 2408 KB (+468 KB compared to latest release) 🚨

Moonriver runtime: 2400 KB (+460 KB compared to latest release) ⚠️

Copy link
Contributor

github-actions bot commented Feb 24, 2025

Coverage Report

@@                          Coverage Diff                           @@
##           master   manuel/allow-usage-of-full-pov-size     +/-   ##
======================================================================
  Coverage   74.51%                                74.51%   0.00%     
  Files         381                                   381             
  Lines       96551                                 96551             
======================================================================
  Hits        71940                                 71940             
  Misses      24611                                 24611             
Files Changed Coverage

Coverage generated Thu Feb 27 14:33:21 UTC 2025

@manuelmauro manuelmauro added the not-breaking Does not need to be mentioned in breaking changes label Feb 24, 2025
RomarQ
RomarQ previously approved these changes Feb 25, 2025
@RomarQ RomarQ marked this pull request as ready for review February 25, 2025 11:37
Copy link
Contributor

@RomarQ RomarQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a look at the test-evm-over-pov2.ts test and it doesn't seem correct, we may take the opportunity to have a look at it.

Some tests test-txpool-limits*.ts can possibly be updated to check this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes D2-notlive PR doesn't change runtime code (so can't be audited) not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants