-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow usage of full PoV size #3198
base: master
Are you sure you want to change the base?
Conversation
WASM runtime size check:Compared to target branchMoonbase runtime: 2420 KB (no changes) 🚨 Moonbeam runtime: 2408 KB (no changes) 🚨 Moonriver runtime: 2400 KB (-12 KB) ✅ Compared to latest release (runtime-3501)Moonbase runtime: 2420 KB (+468 KB compared to latest release) 🚨 Moonbeam runtime: 2408 KB (+468 KB compared to latest release) 🚨 Moonriver runtime: 2400 KB (+460 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master manuel/allow-usage-of-full-pov-size +/- ##
======================================================================
Coverage 74.51% 74.51% 0.00%
Files 381 381
Lines 96551 96551
======================================================================
Hits 71940 71940
Misses 24611 24611
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a look at the test-evm-over-pov2.ts
test and it doesn't seem correct, we may take the opportunity to have a look at it.
Some tests test-txpool-limits*.ts
can possibly be updated to check this change.
What does it do?
Allow usage of full PoV size.
What important points should reviewers know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?