Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade moov-io/go-sftp and record upload errors on spans #221

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

adamdecaf
Copy link
Member

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (9d3ed8b) 49.21% compared to head (acc75f1) 49.16%.

Files Patch % Lines
internal/upload/ftp.go 40.00% 4 Missing and 2 partials ⚠️
internal/upload/sftp.go 60.00% 3 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #221      +/-   ##
==========================================
- Coverage   49.21%   49.16%   -0.05%     
==========================================
  Files          89       89              
  Lines        4123     4139      +16     
==========================================
+ Hits         2029     2035       +6     
- Misses       1766     1773       +7     
- Partials      328      331       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamdecaf adamdecaf merged commit 338a464 into master Feb 1, 2024
7 checks passed
@adamdecaf adamdecaf deleted the sftp-bump-spans branch February 1, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants