Skip to content

Commit

Permalink
Include identifiers when searching in Pontoon (#1040)
Browse files Browse the repository at this point in the history
  • Loading branch information
@flodolo
flodolo authored Sep 17, 2024
1 parent c0671bd commit 5f6e1e1
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion app/classes/Transvision/ShowResults.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ public static function getEditLink($tool, $repo, $key, $text, $locale)
}
}

$edit_link = "https://pontoon.mozilla.org/{$locale}/{$project_name}/{$resource_path}?search={$search_key}";
$edit_link = "https://pontoon.mozilla.org/{$locale}/{$project_name}/{$resource_path}?search_identifiers=true&search_translations_only=true&search={$search_key}";

return "&nbsp;<a class='edit_link' target='_blank' href='{$edit_link}'>&lt;edit in {$tool_name}&gt;</a>";
}
Expand Down
20 changes: 10 additions & 10 deletions tests/units/Transvision/ShowResults.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -458,31 +458,31 @@ public function getEditLinkDP()
'browser/chrome/browser/browser.properties:webextPerms.hostDescription.allUrls',
'test',
'fr',
"&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/fr/firefox/browser/chrome/browser/browser.properties?search=webextPerms.hostDescription.allUrls'>&lt;edit in Pontoon&gt;</a>",
"&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/fr/firefox/browser/chrome/browser/browser.properties?search_identifiers=true&search_translations_only=true&search=webextPerms.hostDescription.allUrls'>&lt;edit in Pontoon&gt;</a>",
],
[
'pontoon',
'comm_l10n',
'calendar/chrome/calendar/calendar.dtd:calendar.calendar.label',
'test',
'fr',
"&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/fr/thunderbird/calendar/chrome/calendar/calendar.dtd?search=calendar.calendar.label'>&lt;edit in Pontoon&gt;</a>",
"&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/fr/thunderbird/calendar/chrome/calendar/calendar.dtd?search_identifiers=true&search_translations_only=true&search=calendar.calendar.label'>&lt;edit in Pontoon&gt;</a>",
],
[
'pontoon',
'comm_l10n',
'chat/commands.properties:dnd',
'test',
'fr',
"&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/fr/thunderbird/chat/commands.properties?search=dnd'>&lt;edit in Pontoon&gt;</a>",
"&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/fr/thunderbird/chat/commands.properties?search_identifiers=true&search_translations_only=true&search=dnd'>&lt;edit in Pontoon&gt;</a>",
],
[
'pontoon',
'gecko_strings',
'browser/browser/preferences/main.ftl:default-content-process-count.label',
'test',
'fr',
"&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/fr/firefox/browser/browser/preferences/main.ftl?search=default-content-process-count'>&lt;edit in Pontoon&gt;</a>",
"&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/fr/firefox/browser/browser/preferences/main.ftl?search_identifiers=true&search_translations_only=true&search=default-content-process-count'>&lt;edit in Pontoon&gt;</a>",
],
[
'pontoon',
Expand All @@ -498,39 +498,39 @@ public function getEditLinkDP()
'mail/chrome/messenger/addressbook/abContactsPanel.dtd:ccButton.label',
'test',
'de',
"&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/de/thunderbird/mail/chrome/messenger/addressbook/abContactsPanel.dtd?search=ccButton.label'>&lt;edit in Pontoon&gt;</a>",
"&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/de/thunderbird/mail/chrome/messenger/addressbook/abContactsPanel.dtd?search_identifiers=true&search_translations_only=true&search=ccButton.label'>&lt;edit in Pontoon&gt;</a>",
],
[
'pontoon',
'comm_l10n',
'suite/chrome/browser/taskbar.properties:taskbar.tasks.composeMessage.description',
'test',
'it',
"&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/it/seamonkey/suite/chrome/browser/taskbar.properties?search=taskbar.tasks.composeMessage.description'>&lt;edit in Pontoon&gt;</a>",
"&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/it/seamonkey/suite/chrome/browser/taskbar.properties?search_identifiers=true&search_translations_only=true&search=taskbar.tasks.composeMessage.description'>&lt;edit in Pontoon&gt;</a>",
],
[
'pontoon',
'mozilla_org',
'mozilla_org/en/banners/firefox-mobile.ftl:banner-firefox-mobile-get-android-title',
'test',
'it',
"&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/it/mozillaorg/en/banners/firefox-mobile.ftl?search=banner-firefox-mobile-get-android-title'>&lt;edit in Pontoon&gt;</a>",
"&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/it/mozillaorg/en/banners/firefox-mobile.ftl?search_identifiers=true&search_translations_only=true&search=banner-firefox-mobile-get-android-title'>&lt;edit in Pontoon&gt;</a>",
],
[
'pontoon',
'android_l10n',
'android_l10n/mozilla-mobile/fenix/app/src/main/res/values/strings.xml:preference_experiments',
'test',
'it',
"&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/it/firefox-for-android/mozilla-mobile/fenix/app/src/main/res/values/strings.xml?search=preference_experiments'>&lt;edit in Pontoon&gt;</a>",
"&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/it/firefox-for-android/mozilla-mobile/fenix/app/src/main/res/values/strings.xml?search_identifiers=true&search_translations_only=true&search=preference_experiments'>&lt;edit in Pontoon&gt;</a>",
],
[
'pontoon',
'firefox_ios',
'firefox_ios/firefox-ios.xliff:4e0bc9d4',
'test',
'it',
"&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/it/firefox-for-ios/firefox-ios.xliff?search=test'>&lt;edit in Pontoon&gt;</a>",
"&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/it/firefox-for-ios/firefox-ios.xliff?search_identifiers=true&search_translations_only=true&search=test'>&lt;edit in Pontoon&gt;</a>",
],
[
'pontoon',
Expand All @@ -555,7 +555,7 @@ public function getEditLinkDP()
'firefox_ios/firefox-ios.xliff:4e0bc9d4',
'%(test)',
'it',
"&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/it/firefox-for-ios/firefox-ios.xliff?search=%25%28test%29'>&lt;edit in Pontoon&gt;</a>",
"&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/it/firefox-for-ios/firefox-ios.xliff?search_identifiers=true&search_translations_only=true&search=%25%28test%29'>&lt;edit in Pontoon&gt;</a>",
],
// Test unknown tool
[
Expand Down

0 comments on commit 5f6e1e1

Please sign in to comment.