Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1836305 - Make a data review form when requesting a data review instead of requiring copy-paste #2080

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

padenot
Copy link

@padenot padenot commented Jun 1, 2023

No description provided.

For each measurements, please provide:
* Measurement Description
* Data Collection Category
* Tracking Bug #
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* Tracking [% terms.Bug %]

Any mention of bug, Bug, Bugzilla, etc. has a matching [% terms.Bug %] variable that must be used. This is the reason for the sanity test failure.

@dklawren dklawren changed the title Make a data review form when requesting a data review instead of requiring copy-paste Bug 1836305 - Make a data review form when requesting a data review instead of requiring copy-paste Jun 1, 2023
Copy link

@chutten chutten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to play with approval-mozilla-beta to figure out how this would intersect with the existing data review process. It appears as though the existing path of

  1. Add attachment that is a plaintext data collection review request
  2. Flag data-review?<a steward>

Will continue to work, though the plaintext version of this template will autofill the comment (it'd be nice if it didn't, but we can live with it).

The augmented flow would be...

  1. Mark an existing attachment data-review? (likely the patch adding the data collection)
  2. Fill in the form as presented by BMO (or dismiss the form with the x and supply the full text yourself)

Is that correct?

(( we'll have to update the wiki to make this clear. ))

--

Overall this appears to be a lovely augmentation for anyone who is filling out these forms piecemeal today on BMO. The additional maintenance burden of updating the data review request in one more place is very small.

@dklawren
Copy link
Collaborator

dklawren commented Jun 5, 2023

The augmented flow would be...

1. Mark an existing attachment `data-review?` (likely the patch adding the data collection)

2. Fill in the form as presented by BMO (or dismiss the form with the `x` and supply the full text yourself)

Is that correct?

Yes it is correct. If the user clicks X then the form disappears and they can enter whatever they like.

@dklawren
Copy link
Collaborator

dklawren commented Jul 5, 2023

Sorry that this slipped off my radar. Is there anything else I can do to help resolve this change?

@padenot
Copy link
Author

padenot commented Jul 5, 2023

No it slipped of mine as well, will fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants