AUT-105: GitHub workflow for testing #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmhodges
reviewed
Sep 9, 2024
Comment on lines
+333
to
+335
| // For the purpose of testing - ensure we're using IPv4. | ||
| conf.BaseURL = "http://127.0.0.1:8000/" | ||
|
|
There was a problem hiding this comment.
I know we're just doing minimal changes in this PR, so this is not for this change, but I've written the code that does random port allocation so often that I now can't not mention it. Code like this would allow us to run the tests even if we have port 8000 consumed:
jmhodges
approved these changes
Sep 9, 2024
oskirby
force-pushed
the
aut-105-github-workflows
branch
2 times, most recently
from
fb14f44
to
98af22c
Compare
oskirby
force-pushed
the
aut-105-github-workflows
branch
from
98af22c
to
e2df879
Compare
|
Sorry for the rebasing chaos - I am learning how to sign commits on Github :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a github workflow to run the unit and integration tests for pull requests and on merge to the
mainbranch.Along the way we also encountered a flaky test that needed fixing. In particular connections to
http://localhost:8000don't result in deterministic error messages becauselocalhostcan resolve to either127.0.0.1or[::]. To get a consistent result we needed to force the tests to use a fixed localhost address.