Deng 3996 add jinja config to snapshot #5729
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scholtzan
reviewed
Jun 4, 2024
sql/moz-fx-data-shared-prod/braze_external/users_previous_day_snapshot_v1/script.sql
Outdated
Show resolved
Hide resolved
sql/moz-fx-data-shared-prod/braze_external/users_previous_day_snapshot_v1/metadata.yaml
Outdated
Show resolved
Hide resolved
…snapshot_v1/script.sql Co-authored-by: Anna Scholtz <[email protected]>
…snapshot_v1/metadata.yaml Co-authored-by: Anna Scholtz <[email protected]>
This comment has been minimized.
This comment has been minimized.
scholtzan
approved these changes
Jun 4, 2024
lelilia
reviewed
Jun 4, 2024
| @@ -19,3 +19,5 @@ bigquery: | |||
| scheduling: | |||
| dag_name: bqetl_braze | |||
| date_partition_parameter: null | |||
| parameters: | |||
| - "snapshot_interval:INT64:1" | |||
There was a problem hiding this comment.
ok but ... can you overwrite it if you hardcode it?
There was a problem hiding this comment.
not saying you can't ... just not sure
There was a problem hiding this comment.
you can't. you need to define available parameters in Airflow like this: https://github.com/mozilla/telemetry-airflow/blob/5254b94e51020991691a88fb09f8fe43565fc23d/dags/operational_monitoring_backfill.py#L32-L60
But currently the generation logic doesn't support this
There was a problem hiding this comment.
actually one thing to try that could work:
Suggested change
| - "snapshot_interval:INT64:1" | |
| - "snapshot_interval:INT64:{{ dag_run.conf.get('snapshot_interval', 1) }}" |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Integration report for "Update sql/moz-fx-data-shared-prod/braze_external/users_previous_day_snapshot_v1/script.sql"
|
sean-rose
reviewed
Jun 4, 2024
| @@ -2,7 +2,5 @@ DROP SNAPSHOT TABLE `moz-fx-data-shared-prod.braze_external.users_previous_day_s | |||
|
|
|||
| CREATE SNAPSHOT TABLE `moz-fx-data-shared-prod.braze_external.users_previous_day_snapshot_v1` CLONE `moz-fx-data-shared-prod.braze_derived.users_v1` FOR SYSTEM_TIME AS OF TIMESTAMP_SUB( | |||
| CURRENT_TIMESTAMP(), | |||
| INTERVAL 12 HOUR | |||
| INTERVAL snapshot_interval HOUR | |||
There was a problem hiding this comment.
Suggested change
| INTERVAL snapshot_interval HOUR | |
| INTERVAL @snapshot_interval HOUR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal:
Default snapshot interval to 1 HOUR w/ ability to override the snapshot_interval value when triggering the dag w/ config
Checklist for reviewer:
<username>:<branch>of the fork as parameter. The parameter will also show upin the logs of the
manual-trigger-required-for-forkCI task together with more detailed instructions.For modifications to schemas in restricted namespaces (see
CODEOWNERS):┆Issue is synchronized with this Jira Task