-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update everything #120
Update everything #120
Conversation
Also, it appears that the new way Middleman handles Sass files involves trimming off the file extension as it goes. So I dropped in a |
I've been messing around for 20 minutes and getting a working ruby 2.7 environment set up has turned out to be harder than expected. You'll have to wait a bit more for me to review this. |
I know the pain. Been there. Use docker,
Could we maybe just bump everything? It's getting quite hard to test, deploy those old versions. |
Sure, that was my plan eventually, I just didn't want to change too many things in one PR. |
Fortunately no big changes! I had to put in webrick for a second but after updating middleman that issue went away so I dropped it from the Gemfile again. The depreciation warnings are not from us, all are middleman dependencies, so I didn't silence them. |
Just tested, still get that SassC error after bumps. Not sure what that's about |
If the SassC issue is we need the following line, I think we can live with it. config[:sass_assets_paths] << Bootstrap.stylesheets_path This would probably not be needed with later versions of Bootstrap (>4 moved to |
Don't need to specify outdated bundler versions anymore, rbenv/rvm are way easier for people unfamiliar with ruby, and rehash no longer needs to be run explicitly with rbenv as it does so automatically after new gems are installed
Would be interesting to see if bootstrap bumps will fix that. I'm very hesitant to do that in this PR though, SassC's 4 year EOL + two major bumps would definitely add to the diff. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than that: works. thanks for contributing.
Co-authored-by: sfan5 <[email protected]>
The manual no longer has the sidebar and options no longer have hyperlinks associated to them after this https://mpv.io/manual/master/ |
I've pushed a fix but it looks like it's not being built. |
The workflow runs here and every day at 8am. I'll trigger it manually now. |
Would it be welcome if I added Github Actions to automatically deploy on Cloudflare Pages so we can drop Github Pages? It even supports preview links on PRs with can be nice to test changes actually work. |
This was the latest version I could get to before bumping the bundler version, since middleman 4.4 started requiringBumping ruby, bundler, and middleman to their latest versions.bundle ~> 2.0
.middleman has deprecated middleman-sprockets in favor of their
external_pipeline
system, thus the two new calls to that. We don't need an explicit command because these assets are downloaded as part of the gem when we bundle! When the site builds, it drags over some copies of those files into the appropriate directories.This change also now makes all of Bootstrap's JS tooling available if we want it. We're not requiring it in
all.js
atm so it's not actually being loaded on the page for the time being.For some reason, I still need to manually tell SassC where the Bootstrap files are. Not the Font Awesome ones though! I've poked around for a while trying to figure out what's causing this to no avail. No config edit leads to a SassC compile error.