Message Player if Inbox is Full

[AntumDeluge]

Sends text "This mailbox is full." to player if there is no room if setting homedecor.verbose_messages is enabled.

Original message:

Sends text "The mailbox is full." to player if there is no room when trying to deposit an item.

[OgelGames]

I think "This mailbox is full." would be more grammatically correct, because there can be multiple mailboxes.

[SwissalpS]

I don't like chat messages for obvious things.
This PR sends a message to the player putting items into the mailbox. They already see that the inventory is full as their items are being returned to them.
This is the equivelant of sending a success message "Thanks for dropping items". The player already sees that their items have been taken.

It would be another matter, if the owner is getting a message (once, we don't want to create an opportunity for bad actors to spam the owner).
However that would require checking if the owner is online and opens the question about informing them when they join.

An alternative could be to send the owner a /mail "Your mailbox at x, y, z is full".

[BuckarooBanzay]

code looks good, @SwissalpS has a point though, do the returning items really go unnoticed?

[AntumDeluge]

I might agree if the player could see that the mailbox inventory is full or see the result of the drop (e.g. an item dropped on the ground can visibly be seen on the ground). Without inherent knowledge that a mailbox has a capacity limit, players might not understand why their item isn't accepted & may confuse it with a server error.

Perhaps to find a middle ground the notification can be enabled with a setting while being disabled by default.

Edit: For context, my server is used primarily by younger children who often need feedback because they don't understand why something might not work.

[AntumDeluge]

I think "This mailbox is full." would be more grammatically correct, because there can be multiple mailboxes.

Changed.

[SwissalpS]

While I still think it isn't needed, I'm OK with this variant.

[wsor4035]

naming the setting homedecor.verbose_messages seems rather wide scope, when its just for mailboxes

[SwissalpS]

maybe they want to add more messages like: this refrigerator is empty/full etc. :D

Edit: at which point it could just as well be called "homedecor.chat_debugging"